EmbeddedPkg/GdbSerialLib: avoid left shift of negative quantity

Clang complains about left shifting a negative value being undefined.

  EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c:151:30:
  error: shifting a negative signed value is undefined [-Werror,-Wshift-negative-value]
  OutputData = (UINT8)((~DLAB<<7)|((BreakSet<<6)|((Parity<<3)|((StopBits<<2)| Data))));

Redefine all bit pattern constants as unsigned to work around this.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

diff --git a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
index 069d87ca780d41203d7e9fe2dbaae516f1ff06c8..7931d1ac4e2b3cbc9d14dad1294b383bcd761abd 100644 (file)
--- a/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
+++ b/EmbeddedPkg/Library/GdbSerialLib/GdbSerialLib.c
@@ -40,11 +40,11 @@
 //---------------------------------------------\r
 // UART Register Bit Defines\r
 //---------------------------------------------\r
-#define LSR_TXRDY               0x20\r
-#define LSR_RXDA                0x01\r
-#define DLAB                    0x01\r
-#define ENABLE_FIFO             0x01\r
-#define CLEAR_FIFOS             0x06\r
+#define LSR_TXRDY               0x20U\r
+#define LSR_RXDA                0x01U\r
+#define DLAB                    0x01U\r
+#define ENABLE_FIFO             0x01U\r
+#define CLEAR_FIFOS             0x06U\r
 \r
 \r
 \r